Skip to content

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Mar 13, 2023

Fixes #9717

Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but would be good to get confirmation from @lidel or someone else that this is all that needs to be done.

@BigLep BigLep requested a review from guseggert March 14, 2023 16:33
@BigLep
Copy link
Contributor

BigLep commented Mar 14, 2023

@Jorropo : will you be able to incorporate feedback here so we can merge and include in 0.19 release tomorrow?

@BigLep BigLep mentioned this pull request Mar 14, 2023
@Jorropo
Copy link
Contributor Author

Jorropo commented Mar 15, 2023

Flaky unrelated tests.

@Jorropo Jorropo merged commit 1f5763f into ipfs:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Deprecate then Remove /api/v0/pubsub/* RPC API and ipfs pubsub Commands
3 participants