Skip to content

filestore: verify option to remove bad blocks #7474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 4, 2025
Merged

filestore: verify option to remove bad blocks #7474

merged 11 commits into from
Jun 4, 2025

Conversation

ivan386
Copy link
Contributor

@ivan386 ivan386 commented Jun 13, 2020

Verify objects in filestore and remove bad links

License: MIT
Signed-off-by: Ivan ivan386@users.noreply.github.com

Stebalien
Stebalien reviewed Jun 19, 2020
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you write a sharness test? (test/sharness)

@jacobheun
Copy link
Contributor

@ivan386 can you check the linter issue here?

@ivan386
Copy link
Contributor Author

ivan386 commented Jul 10, 2020

@jacobheun I don't have access to it without login.

@aschmahmann
Copy link
Contributor

@ivan386 you can run the linter locally by using golangci-lint run ./... (https://github.com/golangci/golangci-lint).

The linter errors were regarding unchecked errors from use of fs.FileManager().DeleteBlock()

@gammazero gammazero requested a review from a team as a code owner June 3, 2025 22:13
@gammazero
Copy link
Contributor

@gammazero updated PR:

  • Only include remove blocks action in output if removing blocks
  • Update command documentation
  • Wrote sharness test
  • Fixed broken sharness tests
  • Fixed linter warning about missed error check

hsanjuan
hsanjuan approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@hsanjuan hsanjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor nits

gammazero and others added 3 commits June 4, 2025 13:35
@gammazero @hsanjuan
Update core/commands/filestore.go
6ccb566 
Co-authored-by: Hector Sanjuan <code@hector.link>
@gammazero @hsanjuan
Update core/commands/filestore.go
796c058 
Co-authored-by: Hector Sanjuan <code@hector.link>
@gammazero
change remove block action from "nop" to "keep"
7952bfe
@gammazero gammazero merged commit d39cb7f into ipfs:master Jun 4, 2025
17 checks passed
@gammazero gammazero changed the title Ivan386/filestore fix filestore: verify option to remove bad blocks Jun 5, 2025
@BrewTestBot BrewTestBot mentioned this pull request Jul 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien left review comments

@hsanjuan hsanjuan hsanjuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ivan386 @jacobheun @aschmahmann @gammazero @Stebalien @hsanjuan