Skip to content

Conversation

lidel
Copy link
Member

@lidel lidel commented Aug 20, 2025

Summary

  • chore: update to golangci/v2 (2.4.0) which is compatible with go1.25
  • pay off technical debt:
    • align kubo with unified golang ci linter from IPDX and rules used in boxo and other go packages
    • disabled errcheck linter in .golangci.yml (it is disabled in boxo/unified ci)

Addressed lint rules

  • ST1000: added package comments
  • ST1020, ST1021, ST1022: fixed function/method comments
  • QF1001: applied De Morgan's law
  • QF1003: converted if-else chains to tagged switches
  • QF1004: replaced strings.Replace with strings.ReplaceAll
  • QF1008: simplified embedded struct field selectors
  • unconvert: removed unnecessary type conversions
  • usestdlibvars: used stdlib constants instead of literals

lidel added 2 commits August 19, 2025 23:47
align kubo with unified golang ci linter from IPDX and
rules used in boxo and other go packages

addressed lint rules:
- ST1000: added package comments
- ST1020, ST1021, ST1022: fixed function/method comments
- QF1001: applied De Morgan's law
- QF1003: converted if-else chains to tagged switches
- QF1004: replaced strings.Replace with strings.ReplaceAll
- QF1008: simplified embedded struct field selectors
- unconvert: removed unnecessary type conversions
- usestdlibvars: used stdlib constants instead of literals

disabled errcheck linter in .golangci.yml
@lidel lidel added the skip/changelog This change does NOT require a changelog entry label Aug 20, 2025
@lidel lidel mentioned this pull request Aug 19, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does NOT require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant