fix(cmd): exit 1 on error #10903
Merged
fix(cmd): exit 1 on error #10903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not close the stream prematurely in a deferred function. Also, avoid possible shadowing errors. Closes #9007
includes regression tests for #9007 and better coverage than the old test/sharness/t0290-cid.sh (identified bug in basemoji)
changed the character display logic from ASCII range check to unicode.IsPrint() to properly handle Unicode characters including emojis.
lidel
approved these changes
Aug 9, 2025
There was a problem hiding this comment.
Thank you, this + #10897 make ipfs cid pretty useful for scripting/CI, I've added it as a highlight in changelog.
As part of moving away from sharness, I've added regression tests to test/cli + fixed small bug in ipfs cid bases --prefix where unicode 🚀 was not printed correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not close the stream prematurely in a deferred function. Also, avoid possible shadowing errors.
Closes #9007