refactor: remove goprocess #10872
Merged
refactor: remove goprocess #10872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `goprocess` package is no longer needed. It can be replaces by modern `context` and `context.AfterFunc`.
gammazero
commented
Jul 16, 2025
make sure ongoing operations dont block shutdown
opportunistically run FUSE tests if env has fusermount and TEST_FUSE was not explicitly set
lidel
approved these changes
Aug 5, 2025
There was a problem hiding this comment.
Thank you @gammazero for cleaning this up, lgtm.
I've added test/cli that ensures shutdown is clean and also test for FUSE unmounts, so we don't have regressions in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove use of the
goprocesspackageThe
goprocesspackage is no longer needed. It can be replaces by moderncontextandcontext.AfterFunc.