fix: support --flush=false in files rm
#10848
Conversation
| err = pdir.Unlink(name) | ||
| if err != nil { | ||
| return err | ||
| if err := pdir.Unlink(name); err != nil { | ||
| return err | ||
| } | ||
| } | ||
|
|
||
| return pdir.Flush() |
There was a problem hiding this comment.
cc @gammazero @hsanjuan For a sanity check: Do you know if always flushing the parent of the removed item here, while ignoring --flush=false, was a bug or a conscious design decision?
As this PR stands now, I've "fixed" it by adding support for --flush=false, which allows users to skip flushing the parent of the removed item.
Let me know if you have any concerns about this.
There was a problem hiding this comment.
fI do not know if it was intentional. My concern is that this was done for safety, so that the parent would no longer see the child item, which would invalidate any further actions on the child (e.g. moving the child from the parent to another parent).
| Passing '--flush=false' may improve performance for large numbers of file | ||
| operations, but it does so at the cost of consistency guarantees and unbound | ||
| growth of the directories' in-memory caches. | ||
| Make sure to call 'ipfs files flush' after each batch of work. |
There was a problem hiding this comment.
If this warning text is identical for the different commands, please define a const and use that in the help text. Ex: https://go.dev/play/p/8CP7Sz13CzD
| err = pdir.Unlink(name) | ||
| if err != nil { | ||
| return err | ||
| if err := pdir.Unlink(name); err != nil { | ||
| return err | ||
| } | ||
| } | ||
|
|
||
| return pdir.Flush() |
There was a problem hiding this comment.
fI do not know if it was intentional. My concern is that this was done for safety, so that the parent would no longer see the child item, which would invalidate any further actions on the child (e.g. moving the child from the parent to another parent).
|
Triage notes:
|
This PR aims to close #10842:
--flush=falseto--helptext inipfs filescommands that support itipfs files rmignored--flush=falseand always flushed the parent