Skip to content

chore: use go-log/v2 #10801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 19, 2025
Merged

chore: use go-log/v2 #10801

merged 14 commits into from
May 19, 2025

Conversation

gammazero
Copy link
Contributor

@gammazero gammazero commented May 8, 2025 •
edited
Loading

go-log v2 has been out for quite a while now and it is time to deprecate v1.

Replaces: PR #8765

Changes:

  • Replace all use of go-log with go-log/v2
  • Makes /api/v0/log/tail useful over HTTP
  • Updates dependencies that have moved to go-lov/v2
  • Removes support for ContextWithLoggable as this is not needed for tracing-like functionality

Issues addressed:

@gammazero gammazero requested review from lidel and a team as code owners May 8, 2025 16:54
@gammazero gammazero marked this pull request as draft May 10, 2025 06:17
@gammazero gammazero force-pushed the chore/use-go-log-v2 branch from 668d8d2 to e50211d Compare May 12, 2025 18:36
@gammazero gammazero marked this pull request as ready for review May 13, 2025 18:40
@gammazero gammazero marked this pull request as draft May 14, 2025 07:21
@gammazero gammazero marked this pull request as ready for review May 15, 2025 05:44
This was referenced May 16, 2025
Closed
Closed
lidel
lidel approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, small cosmetic asks inline – ok to merge once addressed.

Planning to include this in 0.36.

hsanjuan
hsanjuan requested changes May 17, 2025
View reviewed changes
@gammazero gammazero mentioned this pull request May 19, 2025
Closed
3 tasks
@gammazero gammazero force-pushed the chore/use-go-log-v2 branch from cfc2bbb to 8e3165e Compare May 19, 2025 15:01
@gammazero gammazero requested a review from hsanjuan May 19, 2025 15:02
@gammazero gammazero mentioned this pull request May 19, 2025
Closed
3 tasks
@gammazero gammazero merged commit 20d9660 into master May 19, 2025
16 checks passed
@gammazero gammazero deleted the chore/use-go-log-v2 branch May 19, 2025 20:04
@gammazero gammazero mentioned this pull request May 19, 2025
Closed
3 tasks
@lidel lidel mentioned this pull request May 21, 2025
Closed
46 tasks
@BrewTestBot BrewTestBot mentioned this pull request Jul 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

@hsanjuan hsanjuan hsanjuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ipfs log level does not work "ipfs log tail" doesn't log anything Switch to go-log v2
3 participants
@gammazero @lidel @hsanjuan