-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Closed
Labels
P0Critical: Tackled by core team ASAPCritical: Tackled by core team ASAPeffort/hoursEstimated to take one or several hoursEstimated to take one or several hourskind/bugA bug in existing code (including security flaws)A bug in existing code (including security flaws)status/in-progressIn progressIn progresstopic/gatewayTopic gatewayTopic gateway
Description
Originally reported by Brave: brave/brave-browser#16671
go-ipfs 0.9.0 updated mimetype dep https://github.com/gabriel-vasile/mimetype and that introduced regression on gateway when an empty byte array payload is returned to the user.
Unfortunately, that edge case changes HTTP response for CID bafkqaaa
which we use in various places.
- In v0.8.0 it was empty body with HTTP 200 (ok) status code
- In v0.9.0 it returns
cannot detect content-type: EOF
with HTTP 500 error
TODO
- Switch back to 1.1.2 (safe choice for patch release) – done: fix: downgrade mimetype dependency #8229
We were at 1.1.2 in v0.8.0 the latest is v1.3.0 which seems ok, and v1.2.0 is what we have and has the behavior change
- Add sharness tests – done: test: gateway response for bafkqaaa #8232
stephendonner
Metadata
Metadata
Assignees
Labels
P0Critical: Tackled by core team ASAPCritical: Tackled by core team ASAPeffort/hoursEstimated to take one or several hoursEstimated to take one or several hourskind/bugA bug in existing code (including security flaws)A bug in existing code (including security flaws)status/in-progressIn progressIn progresstopic/gatewayTopic gatewayTopic gateway