Skip to content

using t.Fatal in a goroutine #2043

@whyrusleeping

Description

@whyrusleeping

Apparently (it makes sense thinking about it) you can't use t.Fatal in a goroutine.

A cursory search reveals at least a few occurences of this bug: https://gist.github.com/whyrusleeping/6ff875746eccfc2611ab

Lots of them in our dependencies unfortunately, but a few in our code:
exchange/bitswap/bitswap_test.go-173
fuse/readonly/ipfs_test.go-160
merkledag/merkledag_test.go-198-
test/supernode_client/main.go-145-
test/supernode_client/main.go-183

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedSeeking public contribution on this issuekind/testTesting workneed/verificationThis issue needs verification

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions