Skip to content

denylist: ?format=car does not skip directly blocked CIDs #10361

New issue
New issue
Open
Open
denylist: ?format=car does not skip directly blocked CIDs#10361
Labels
kind/bugA bug in existing code (including security flaws)need/triageNeeds initial labeling and prioritization
@lidel

Description

@lidel
lidel
opened on Mar 1, 2024

Checklist

Installation method

built from source

Version

0.26

Config

default

Description

?format=car does not skip directly blocked CIDs.

Repro in commented block of #10360:

kubo/test/cli/content_blocking_test.go

Lines 118 to 131 in 92acc24

/* TODO: this was already broken in 0.26, but we should fix it
t.Run("Gateway returns CAR without directly blocked CID", func(t *testing.T) {
allowedDirWithDirectlyBlockedCID := node.IPFS("add", "--raw-leaves", "-Q", "-rw", filepath.Join(h.Dir, "directly-blocked-file.txt")).Stdout.Trimmed()
resp := client.Get("/ipfs/" + allowedDirWithDirectlyBlockedCID + "?format=car")
assert.Equal(t, http.StatusOK, resp.StatusCode)
bs, err := carstore.NewReadOnly(strings.NewReader(resp.Body), nil)
assert.NoError(t, err)
has, err := bs.Has(context.Background(), cid.MustParse(blockedCID))
assert.NoError(t, err)
assert.False(t, has, "Returned CAR should not include blockedCID")
})
*/

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugA bug in existing code (including security flaws)need/triageNeeds initial labeling and prioritization

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions