-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Open
Labels
kind/enhancementA net-new feature or improvement to an existing featureA net-new feature or improvement to an existing featuretopic/providerTopic providerTopic provider
Description
Checklist
- My issue is specific & actionable.
- I am not suggesting a protocol enhancement.
- I have searched on the issue tracker for my issue.
Description
The same system is managing provides and reprovides. Having 2 distinct configs for it is confusing.
Besides, reproviding is a DHT specific behaviour, and may not apply to other providing systems. In a world where the DHT implementation works perfectly as expected, most users don't need to know that there is a reprovide operation.
The Reprovider
config can be deprecated.
There are currently 2 parameters in the Reprovider
config:
Reprovider.Strategy
->Provider.Strategy
Reprovider.Interval
should be specific to each DHT with providing enabled, in a world where we use configurable routers/DHTs (see the composable routers should be powerfull enough to configure multi-dhts setups and we should drop the adhoc dht dual #10075). As a first step, we could move it toProvider.ReprovideInterval
orProvider.DHT.ReprovideInterval
.
Ideally, other provider/reprovider options that are specific to a routing system, should be configured as part of the routing system itself.
Related: #10886 (comment), #10834 (comment)
Metadata
Metadata
Assignees
Labels
kind/enhancementA net-new feature or improvement to an existing featureA net-new feature or improvement to an existing featuretopic/providerTopic providerTopic provider