Skip to content

kubo 0.35.0-rc1: missing Provide.Enabled flag #10803

@lidel

Description

@lidel

Checklist

Installation method

dist.ipfs.tech or ipfs-update

Version

0.35.0-rc1

Config

default

Description

Kubo has ability to disable DHT announcements by setting Reprovider.Interval to 0.

(Un)fortunately 0.35.0-rc1 (#10760) included ipfs/boxo#907 which introduced separate queue for initial provides, which does not seem to be covered by this setting, which makes it impossible to disable DHT announcements of newly added data.

Proposed fix

  • Introduce explicit Provider.Enabled (type Flag, true by default) for controlling initial provides
    • OR should it be Provider.Strategy as OptionalString and two options all|off with all being default (allowing us to have more in future?)
    • Keep it a bool for clarity.
  • To keep things simple, disable both systems if either Reprovider.Interval=0 or Provider.Enabled=false + log a message informing user that provides are disabled as well, to remove any surprises.
    • We can do deeper refactor later, to allow disabling each one separately.

Metadata

Metadata

Assignees

Labels

P0Critical: Tackled by core team ASAPkind/bugA bug in existing code (including security flaws)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions