-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Closed
Labels
P0Critical: Tackled by core team ASAPCritical: Tackled by core team ASAPkind/bugA bug in existing code (including security flaws)A bug in existing code (including security flaws)
Description
Checklist
- This is a bug report, not a question. Ask questions on discuss.ipfs.tech.
- I have searched on the issue tracker for my bug.
- I am running the latest kubo version or have an issue updating.
Installation method
dist.ipfs.tech or ipfs-update
Version
0.35.0-rc1
Config
default
Description
Kubo has ability to disable DHT announcements by setting Reprovider.Interval
to 0
.
(Un)fortunately 0.35.0-rc1 (#10760) included ipfs/boxo#907 which introduced separate queue for initial provides, which does not seem to be covered by this setting, which makes it impossible to disable DHT announcements of newly added data.
Proposed fix
- Introduce explicit
Provider.Enabled
(typeFlag
, true by default) for controlling initial provides- ❓
OR should it beProvider.Strategy
asOptionalString
and two optionsall|off
withall
being default (allowing us to have more in future?) - Keep it a bool for clarity.
- ❓
- To keep things simple, disable both systems if either
Reprovider.Interval=0
orProvider.Enabled=false
+ log a message informing user that provides are disabled as well, to remove any surprises.- We can do deeper refactor later, to allow disabling each one separately.
Metadata
Metadata
Assignees
Labels
P0Critical: Tackled by core team ASAPCritical: Tackled by core team ASAPkind/bugA bug in existing code (including security flaws)A bug in existing code (including security flaws)