feat(bitswap): add option to disable Bitswap server #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on using nil check
gammazero
reviewed
Apr 29, 2025
gammazero
reviewed
Apr 29, 2025
gammazero
approved these changes
Apr 30, 2025
1 task
This was referenced May 5, 2025
This was referenced Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from feat(config): ability to disable Bitswap fully or just server #10782
This pull request introduces the ability to enable or disable the server functionality in the
Bitswapcomponent, along with associated updates to the codebase and new tests. The changes ensure thatBitswapcan operate in a client-only mode when the server is disabled, while maintaining backward compatibility.Core functionality changes:
serverEnabledfield to theBitswapstruct, defaulting totrue, and updated theNewfunction to conditionally initialize the server based on this flag.Stat,NotifyNewBlocks,PeerConnected, andPeerDisconnectedto handle cases where the server is disabled, ensuring no server-related operations are performed in this mode.New configuration option:
WithServerEnabledoption to allow users to explicitly enable or disable the server when creating aBitswapinstance.Testing enhancements:
TestWithServerDisabled, to verify thatBitswapoperates correctly in client-only mode, including requesting blocks, handlingStatoutput, and ensuring no responses to incoming requests.TestServerDisabledNotifyNewBlocksto confirm that theNotifyNewBlocksmethod works as expected when the server is disabled.