Reprovide Sweep interface #995
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81c072d to
0505d4e
Compare
0505d4e to
7f108e8
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #995 +/- ##
==========================================
+ Coverage 60.47% 60.49% +0.01%
==========================================
Files 267 267
Lines 33246 33278 +32
==========================================
+ Hits 20107 20133 +26
- Misses 11475 11478 +3
- Partials 1664 1667 +3
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
14 tasks
42 tasks
7ea011c to
8b6d074
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to ipfs/kubo#10834
Warning
Don't merge before ipfs/kubo#10834 is ready to be merged, otherwise kubo compatibility will be broken
This builds on top of #976 to use the latest Provide interface as defined by the Reprovide Sweep.
It is necessary since Kubo will start using the new provide interface, and won't be able to satisfy the old provide interface required by boxo. Under the hoods, it is still possible to keep the same behavior as before this PR by using a wrapper around the old provider interface.