Skip to content

[skip changelog] fix sending empty want from #968 #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2025
Merged

[skip changelog] fix sending empty want from #968 #975

merged 1 commit into from
Jul 8, 2025

Conversation

Dreamacro
Copy link
Contributor

#968 has been changed from index filling to direct append, so when making a new slice, we need to declare cap instead of length.

out := make([]Entry, 10)
out = append(out, item)
len(out) // 11

@Dreamacro Dreamacro requested a review from a team as a code owner July 8, 2025 07:09
@Dreamacro Dreamacro mentioned this pull request Jul 8, 2025
Merged
@codecov Codecov
Copy link

codecov bot commented Jul 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.59%. Comparing base (1db45db) to head (e1c5c2f).
Report is 1 commits behind head on main.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #975   +/-   ##
=======================================
  Coverage   61.58%   61.59%           
=======================================
  Files         254      254           
  Lines       31420    31420           
=======================================
+ Hits        19350    19352    +2     
+ Misses      10496    10494    -2     
  Partials     1574     1574
Files with missing lines Coverage Δ
bitswap/message/message.go 78.59% <100.00%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gammazero gammazero merged commit 7206ec2 into ipfs:main Jul 8, 2025
13 checks passed
@Dreamacro Dreamacro deleted the fix-send-want branch July 8, 2025 09:51
@BrewTestBot BrewTestBot mentioned this pull request Jul 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gammazero gammazero gammazero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dreamacro @gammazero