Fix sending extra wants #968
Merged
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible for extra wants to be send due to an error causing additional wants to be left in a reused buffer. This fixes the problem by correctly truncating the buffer.
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #968 +/- ##
==========================================
- Coverage 61.63% 61.56% -0.08%
==========================================
Files 254 254
Lines 31427 31427
==========================================
- Hits 19370 19348 -22
- Misses 10486 10501 +15
- Partials 1571 1578 +7
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Dreamacro
pushed a commit
to Dreamacro/boxo
that referenced
this pull request
Jul 8, 2025
Dreamacro
added a commit
to Dreamacro/boxo
that referenced
this pull request
Jul 8, 2025
gammazero
pushed a commit
that referenced
this pull request
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for extra wants to be send due to an error causing additional wants to be left in a reused buffer. This fixes the problem by correctly truncating the buffer.