bitswap/client: Set DontHaveTimeout MinTimeout to 50ms #965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user says that 25ms helps but not fully resolves the issue of disconnects on spikes. So let's bump this a bit more..
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #965 +/- ##
==========================================
+ Coverage 61.54% 61.58% +0.04%
==========================================
Files 254 254
Lines 31400 31400
==========================================
+ Hits 19324 19338 +14
+ Misses 10499 10489 -10
+ Partials 1577 1573 -4
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
guillaumemichel
approved these changes
Jun 30, 2025
|
I am also interested in the setting of this minimum value. Currently, I plan to set it to 200ms for the pure intranet. I want to know where the discussion related to "The user says that 25ms helps" is taking place. |
gammazero
approved these changes
Jul 2, 2025
|
@Dreamacro it comes from ipfs/go-ds-crdt#285 Note that in the "pure internet" I suspect that if a latency is x25 the average probably there is a problem. This affects localhost, where latency is 2ms and a slow disk-read can cause a 25x spike easily. |
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user says that 25ms helps but not fully resolves the issue of disconnects on spikes. So let's bump this a bit more..