Skip to content

Conversation

hsanjuan
Copy link
Contributor

No description provided.

@hsanjuan hsanjuan requested a review from a team as a code owner June 26, 2025 13:41
@hsanjuan hsanjuan self-assigned this Jun 26, 2025
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Project coverage is 61.58%. Comparing base (44137d7) to head (8deebe5).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
bitswap/network/httpnet/httpnet.go 7.14% 11 Missing and 2 partials ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #964      +/-   ##
==========================================
- Coverage   61.65%   61.58%   -0.08%     
==========================================
  Files         254      254              
  Lines       31397    31409      +12     
==========================================
- Hits        19358    19342      -16     
- Misses      10470    10493      +23     
- Partials     1569     1574       +5     
Files with missing lines Coverage Δ
bitswap/network/httpnet/httpnet.go 65.63% <7.14%> (-1.67%) ⬇️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but if we did strings.TrimSpace(h) before doing the checks, it would be less annoying if someone has valid domain but with unnecessary trailing/leading space.

@lidel lidel mentioned this pull request Jun 26, 2025
46 tasks
@hsanjuan
Copy link
Contributor Author

lgtm, but if we did strings.TrimSpace(h) before doing the checks, it would be less annoying if someone has valid domain but with unnecessary trailing/leading space.

True, let me change that before merge

@hsanjuan hsanjuan merged commit 8abf4db into main Jun 27, 2025
16 checks passed
@hsanjuan hsanjuan deleted the input-validation-allowlists branch June 27, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants