Skip to content

Conversation

dmitry-markin
Copy link
Contributor

Correctly handle Bitswap protobuf messages without Wantlist field.

@dmitry-markin dmitry-markin requested a review from a team as a code owner June 25, 2025 06:53
Copy link

welcome bot commented Jun 25, 2025

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

Copy link

codecov bot commented Jun 25, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 61.58%. Comparing base (1f89f55) to head (e083031).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
bitswap/message/message.go 50.00% 4 Missing and 2 partials ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
- Coverage   61.61%   61.58%   -0.04%     
==========================================
  Files         254      254              
  Lines       31425    31427       +2     
==========================================
- Hits        19363    19354       -9     
- Misses      10489    10499      +10     
- Partials     1573     1574       +1     
Files with missing lines Coverage Δ
bitswap/message/message.go 81.41% <50.00%> (+0.11%) ⬆️

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gammazero gammazero merged commit 6140bd8 into ipfs:main Jul 2, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants