bitswap/httpnet: adjust error logging #958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved some error logging to warn level. The errors are useful when figuring out why something is not loading from somewhere (particularly in an scenario where an allowlist is configured), but in an all-open setup they will spam the logs. Default log level is error I think, so warn messages should not show and can be activated without getting into the debug details. Fixes #955. Fixes #954.
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #958 +/- ##
=======================================
Coverage 61.59% 61.59%
=======================================
Files 254 254
Lines 31401 31400 -1
=======================================
Hits 19341 19341
+ Misses 10487 10486 -1
Partials 1573 1573
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
lidel
approved these changes
Jun 23, 2025
| @@ -522,7 +522,7 @@ WANTLIST_LOOP: | |||
| // error handling | |||
| switch result.err.Type { | |||
| case typeFatal: | |||
| log.Errorf("fatal error. Disconnecting from %s: %s", sender.peer, result.err.Err) | |||
| log.Warnf("disconnecting from %s: %s", sender.peer, result.err.Err) | |||
There was a problem hiding this comment.
💭 warning is fine for Kubo (default is error) but if folks run their boxes with info i have a gut feeling this may still get annoying once we have a lot of HTTP providers
but we will re-evaluate once Kubo 0.36 ships
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved some error logging to warn level.
The errors are useful when figuring out why something is not loading from somewhere (particularly in an scenario where an allowlist is configured), but in an all-open setup they will spam the logs. Default log level is error I think, so warn messages should not show and can be activated without getting into the debug details.
Fixes #955.
Fixes #954.