Do not return error from notify blocks when bitswap shutdown #947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lock. This results in an error because bitswap is shutdown, even though there is no real error to address. To fix this, this PR changes NotifyNewBlocks to not return any error if bitswap is closed. Reporting this error is not necessary because there is not action that can or should be taken to handle it, and bitswap was closed intentionally so this is not even an unexpected situation.
b15563f to
34f0ac3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On ipfs shutdown, MFS closes its root which adds an empty directory block. This results in an error because bitswap is shutdown, even though there is no real error to address.
To fix this, this PR changes NotifyNewBlocks to not return any error if bitswap is closed. Reporting this error is not necessary because there is not action that can or should be taken to handle it, and bitswap was closed intentionally so this is not even an unexpected situation.