Skip to content

Conversation

overallteach
Copy link
Contributor

In Go 1.21, the standard library includes built-in max/min function, which can greatly simplify the code.

Signed-off-by: overallteach <cricis@foxmail.com>
@overallteach overallteach requested review from lidel and a team as code owners June 11, 2025 11:59
Copy link

welcome bot commented Jun 11, 2025

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@hsanjuan hsanjuan added the kind/generated This issue might have been automatically generated label Jun 13, 2025
Copy link

It seems this issue might have been automatically generated. To help us address it effectively, please provide additional details.

We value the use of LLMs for code generation and welcome your contributions but please ensure your submission is of such quality that a maintainer will spend less time reviewing it than implementing it themselves. Verify the code functions correctly and meets our standards. If your change requires tests, kindly include them and ensure they pass.

If no further information is provided, the issue will be automatically closed in 7 days. Thank you for your understanding and for aiding us in maintaining quality contributions!

@github-actions github-actions bot added the need/author-input Needs input from the original author label Jun 14, 2025
@overallteach
Copy link
Contributor Author

Not LLMs. This change can make the code more clean.

Copy link

codecov bot commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.59%. Comparing base (6d9782e) to head (887767f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
gateway/backend_blocks.go 0.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #941      +/-   ##
==========================================
- Coverage   61.59%   61.59%   -0.01%     
==========================================
  Files         254      254              
  Lines       31400    31396       -4     
==========================================
- Hits        19341    19337       -4     
+ Misses      10487    10486       -1     
- Partials     1572     1573       +1     
Files with missing lines Coverage Δ
ipld/merkledag/coding.go 77.86% <100.00%> (-0.17%) ⬇️
gateway/backend_blocks.go 46.40% <0.00%> (+0.23%) ⬆️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gammazero gammazero merged commit dca5a72 into ipfs:main Jun 24, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/generated This issue might have been automatically generated need/author-input Needs input from the original author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants