feat(gateway): implement request concurrency limit #887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gitsrc <34047788+gitsrc@users.noreply.github.com>
Signed-off-by: gitsrc <34047788+gitsrc@users.noreply.github.com>
|
Triage notes: this will be triaged as part Kubo v0.35 (@lidel ) |
|
Triage notes: moving to |
|
Triage notes: @lidel is still on it, has not forgotten about, will be dealt with in due time. |
|
This endeavor needs more metrics and tests and integration with timeouts. The atomic.AddInt32 proposed in this PR is ok, however feels like not the best tool for the job. Let's go with more idiomatic semaphore approach from #994 which has lower risk of busy-waiting/checking/mutating shared int value in a tight loop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a mechanism to limit the number of concurrent in-flight HTTP requests to the gateway.
This change enhances gateway's resilience and prevents overload by limiting concurrent requests.
#881