feat: add support for DNS Zones #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8b36e4b to
044fed3
Compare
cristiGuranIonos
approved these changes
Dec 12, 2023
| newConfig.WaitTime = helpers.MaxWaitTime | ||
| newConfig.HTTPClient = &http.Client{Transport: CreateTransport()} | ||
| newConfig.UserAgent = fmt.Sprintf( | ||
| "terraformer_ionos-cloud-sdk-go/%s_os/%s_arch/%s", ionoscloud.Version, runtime.GOOS, runtime.GOARCH) |
There was a problem hiding this comment.
dns in user_agent. also dns.Version
There was a problem hiding this comment.
@cristiGuranIonos solved in cfae8bc
044fed3 to
cfae8bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this fix or implement?
Checklist
feat:/fix:/doc:/refactor:)README.mdupdatedIonos Clouddoc updatedIonos Cloud Terraformerdoc updated - for this one please create a separate PR on the doc repo