This repository was archived by the owner on Apr 6, 2020. It is now read-only.
Steve was on a plane #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| pub fn remap() { | ||
| unsafe { |
There was a problem hiding this comment.
Woo, this is great! boot.asm is looking really clean :D
This commit does two things: first, it removes the setup_SSE, as we are not actually using SSE instructions. This was introduced when following Phil's tutorial long ago, but now we have a libcore that doesn't use SSE at all, so this should be fine. Second, we move the PIC stuff into Rust. It's just some outb/inb calls, no need to keep it in assembly.
More minimal
We aren't using these, currently.
dcf3fe3 to
014fec1
Compare
|
I have rebased away the gets stuff, and removed the stuff that conflicted with @nxnfufunezn 's PR. Let's see how it goes 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to sleep on a flight, but couldn't and ended up hacking on some stuff. I'm not sure that this is good enough to merge, but maybe some commits are, but I'm opening this PR in case anyone wants to check it out and give some feedback.