This repository was archived by the owner on Apr 6, 2020. It is now read-only.
Add keymap for keys with shift modifier #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e8808f to
f391ed2
Compare
|
|
||
| pub struct Keyboard; | ||
|
|
||
| impl Keyboard { | ||
| pub fn handle_keys(&self, scancode: usize) { | ||
| if scancode <= 59 { | ||
| kprint!("{}", KBDUS[scancode] as char); | ||
| let state = STATE.lock(); | ||
| if state.shift ^ state.caps { |
There was a problem hiding this comment.
Is this is the expected behavior for caps & shift being pressed? I don't really know if there is a set standard, but on Mac OS X when caps lock is on the key pressed is always caps.
There was a problem hiding this comment.
IIRC mac caps lock works differently that's why...
|
This needs to be rebased due to lockfiles, would you mind doing so? Thanks! |
|
@steveklabnik done! |
|
Thanks! :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.