This repository was archived by the owner on Apr 6, 2020. It is now read-only.
Interrupt refactor #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also simplify a bit. This will get worse before it gets better.
It wasn't being used, at all.
Remove the macros to define interrupt handlers. While the macros are much more concise, they're also more confusing. Let's just remove this for now.
well, through rust, anyway
The selector and flags are hard coded, but that's okay for now.
We aren't using these for anything right now, so just don't worry about them. It will make editing these files a bit easier.
We don't need it to be static.
| extern crate vga; | ||
|
|
||
| extern { | ||
| fn isr0(); |
|
Awesome work! It seems that you don't use naked functions? Why not? |
|
I've been following along with your development and it's looking great to me! Excited for the upcoming work on the kernel 👍 |
|
Merging this for now, because it's still an improvement. I'll open issues for the other stuff. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big refactoring of the way interrupts are handled. I took some inspiration from @phil-opp, @emk, Redox, (specifically, @ticki) and an
inb/outbcombo from @thepowersgang. All different bits of their OSes' code and several OSDev/OSDevr tutorials. Whew!These commits should probably be cleaned up, and this isn't even quite in a final state; I should be using a
lazy_staticrather than making thingsCopy, and I would like to move a lot of these home-grown structures to thex86crate instead. But before I do, I wanted to have written it all myself. Ha!Thoughts, all?