This repository was archived by the owner on Apr 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 79
Update build instructions for xargo. #146
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleygwilliams
suggested changes
Sep 25, 2016
@@ -2,55 +2,27 @@ | |||
|
|||
Okay, time for the big finale: printing our `OKAY` from Rust. First, let's | |||
change our `Makefile` to add the Rust code into our assembly code. We can build | |||
on the steps we did earlier. Here's some new rules to add to the `Makefile`: | |||
on the steps we did earlier. Here's a new rules to add to the `Makefile`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a new rule or some new rules ;)
into these three rules is. | ||
|
||
Try it out: | ||
This uses `xargo` to automatically cross-compile `libcore` for us. Easy! Let's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cross compile what to what
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(a nice place to reiterate what xargo does IMO)
back to things, check back with this chapter to see if you need to upgrade. | ||
This installs the current version of nightly Rust. We run all of the examples | ||
in this book under continunous integration, so we should know if something | ||
changes in nightly Rust and breaks. But please file bugs if something doesn't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link to issues here
Paired with intermezzOS/kernel#62, this now uses xargo rather than our own fork of libcore.
Fixed! |
ok seems fine plz never force push again tho k thx |
ashleygwilliams
approved these changes
Sep 25, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired iwth intermezzOS/kernel#62, this now uses
xargo rather than our own fork of libcore.