This repository was archived by the owner on Apr 6, 2020. It is now read-only.
including install script in appendix and editing copy of osx.md file #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to reflect new script
| @@ -35,3 +35,4 @@ | |||
| ----------- | |||
| [Appendix A: Troubleshooting](appendix/troubleshooting.md) | |||
| [Appendix B: Numeral Systems](appendix/numeral-systems.md) | |||
| [Appendix C: Mac OS X Install Script](appendix/osx-install.sh) | |||
There was a problem hiding this comment.
This needs to be .html, not .sh.
There was a problem hiding this comment.
Are you sure it shouldn't be .md like the Appendix A and Appendix B?
There was a problem hiding this comment.
oh whoops, you are 100% correct, I mistyped 😓
|
A few nits. Thanks again for doing this 😄 |
| @@ -22,7 +22,7 @@ installed in `~/opt`. This is so we don't clobber any version of them that you | |||
| may have already installed. The source code for these tools are downloaded in | |||
| `~/src`. | |||
|
|
|||
| [this script]: https://gist.githubusercontent.com/emkay/a1214c753e8c975d95b4/raw/cc73290537898799fe1168edfbc5a41351184670/build-grub-osx.sh | |||
| [this script]: https://intermezzos.github.io/book/appendix/osx-install.html | |||
There was a problem hiding this comment.
ah, last nit: can you make this link appendix/osx-install.html? the relative link means it will work locally as well as when it's published
|
Thanks so much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to include Mac OS X install script in the book repository and edit it to fetch GCC from a GNU FTP mirror. Also added more brew installs to the script. Also appropriately edited the osx.md file to link to this new location and removed lines about installing more brew tools after cross compile steps.