-
-
Notifications
You must be signed in to change notification settings - Fork 504
Shellcheck #2775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shellcheck #2775
Conversation
Signed-off-by: pranjalg1331 <pranjaloff13@gmail.com>
Signed-off-by: pranjalg1331 <pranjaloff13@gmail.com>
Signed-off-by: pranjalg1331 <pranjaloff13@gmail.com>
Signed-off-by: pranjalg1331 <pranjaloff13@gmail.com>
Signed-off-by: pranjalg1331 <pranjaloff13@gmail.com>
Signed-off-by: pranjalg1331 <pranjaloff13@gmail.com>
Signed-off-by: pranjalg1331 <pranjaloff13@gmail.com>
Signed-off-by: pranjalg1331 <pranjaloff13@gmail.com>
Signed-off-by: pranjalg1331 <pranjaloff13@gmail.com>
I have integrated CICDTookbox/shellcheck . It performs static code analysis on shell scripts using ShellCheck. It also includes customizations of include_files, exclude files, and a summary of report in the end. |
Nice! Any particular reason on why you didn't choose the linter that you mentioned in the Medium article ? |
Reason for using CICDTookbox/shellcheck: The one by CICDToolbox had all the customizations like the one in the medium article and more like reports. I had concerns regarding adding it to pre-commit - Would it be wise to put so many restrictions on commits since it can slow down the development? |
I was thinking about pre-commit hook because I thought it would have been easier that push the code, wait for CI to run to get errors, fix them and push again. But if it takes more than 10 seconds like in CI it would consistently slow down development as you said. Can you do some test on how much time it takes to run in pre-commit please ? |
Signed-off-by: pranjalg1331 <pranjaloff13@gmail.com>
Signed-off-by: pranjalg1331 <pranjaloff13@gmail.com>
Signed-off-by: pranjalg1331 <pranjaloff13@gmail.com>
Signed-off-by: pranjalg1331 <pranjaloff13@gmail.com>
Looks really good! How much does it take for it to run ? Also, it is run only when detects changes to script files ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When these are fixed I will test also other script, thank you
Signed-off-by: pranjalg1331 <pranjaloff13@gmail.com>
Signed-off-by: pranjalg1331 <pranjaloff13@gmail.com>
6d9a9a6
to
e03e633
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple minor things and we can merge, thanks!
Co-authored-by: Federico Gibertoni <152909479+fgibertoni@users.noreply.github.com>
Co-authored-by: Federico Gibertoni <152909479+fgibertoni@users.noreply.github.com>
Co-authored-by: Federico Gibertoni <152909479+fgibertoni@users.noreply.github.com>
Nice work! Thanks 😄 |
(Please add to the PR name the issue/s that this PR would close if merged by using a Github keyword. Example:
<feature name>. Closes #999
. If your PR is made by a single commit, please add that clause in the commit too. This is all required to automate the closure of related issues.)Description
Please include a summary of the change and link to the related issue.
Closes #2731
Type of change
Please delete options that are not relevant.
Checklist
develop
dumpplugin
command and added it in the project as a data migration. ("How to share a plugin with the community")test_files.zip
and you added the default tests for that mimetype in test_classes.py.FREE_TO_USE_ANALYZERS
playbook by following this guide.url
that contains this information. This is required for Health Checks._monkeypatch()
was used in its class to apply the necessary decorators.MockUpResponse
of the_monkeypatch()
method. This serves us to provide a valid sample for testing.# This file is a part of IntelOwl https://github.com/intelowlproject/IntelOwl # See the file 'LICENSE' for copying permission.
Black
,Flake
,Isort
) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.tests
folder). All the tests (new and old ones) gave 0 errors.DeepSource
,Django Doctors
or other third-party linters have triggered any alerts during the CI checks, I have solved those alerts.Important Rules