Skip to content

Conversation

clangenb
Copy link
Contributor

This implementation should actually be independent of the polkadot-v0.9.42 update, I will also rebase this branch on master and file a standalone pr.

pub unjustified_headers: Vec<Block::Hash>, // Finalized headers without grandpa proof
pub verify_tx_inclusion: Vec<OpaqueExtrinsic>, // Transactions sent by the relay
pub scheduled_change: Option<ScheduledChangeAtBlock<Block::Header>>, // Scheduled Authorities change as indicated in the header's digest.
}

impl<Block: BlockT> RelayState<Block> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo to me: introduce separate datatype instead of implementing this on the RelayState itself, and do some testing

Comment on lines +251 to +253
/// Light client db seal.
pub static GLOBAL_LIGHT_CLIENT_SEAL: ComponentContainer<EnclaveLightClientSeal> =
ComponentContainer::new("EnclaveLightClientSealSync");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to introduce a separate component to access this in the tls-ra domain

Comment on lines -38 to -44
where
ShieldingKeyRepository: AccessKey<KeyType = Rsa3072KeyPair> + MutateKey<Rsa3072KeyPair>,
StateKeyRepository: AccessKey<KeyType = Aes> + MutateKey<Aes>,
// Constraint StateT = StfState currently necessary because SgxExternalities Encode/Decode does not work.
// See https://github.com/integritee-network/sgx-runtime/issues/46.
StateHandler: HandleState<StateT = StfState>,
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary type constraints on the type definition

@clangenb
Copy link
Contributor Author

clangenb commented Aug 1, 2023

I can't explain currently, why I see the following erros in the failing integration tests:

[init ../../../psw/ae/aesm_service/source/core/ipc/UnixCommunicationSocket.cpp:225] Failed to connect to socket /var/run/aesmd/aesm.socket
[2023-08-01T05:58:25Z ERROR integritee_service::ocall_bridge::ffi::init_quote] [-]  Failed to init quote: InitQuote(SGX_ERROR_SERVICE_UNAVAILABLE)
[2023-08-01T05:58:25Z ERROR itp_stf_executor::executor] Fatal Error. Failed to attempt call execution: Sgx(SGX_ERROR_SERVICE_UNAVAILABLE)

@OverOrion
Copy link
Contributor

OverOrion commented Aug 1, 2023

[init ../../../psw/ae/aesm_service/source/core/ipc/UnixCommunicationSocket.cpp:225] Failed to connect to socket /var/run/aesmd/aesm.socket
[2023-08-01T05:58:25Z ERROR integritee_service::ocall_bridge::ffi::init_quote] [-]  Failed to init quote: 
InitQuote(SGX_ERROR_SERVICE_UNAVAILABLE)
[2023-08-01T05:58:25Z ERROR itp_stf_executor::executor] Fatal Error. Failed to attempt call execution: >Sgx(SGX_ERROR_SERVICE_UNAVAILABLE)

This sometimes happens, because we are really pushing those machines when running the tests in parallel, and we (@mosonyi and I) suspect that the aesmd service might not be really suited for this type of workload. Rerunning usually solves it. (The solution would be to have as much runners as needed but this error rarely happens.)

@clangenb
Copy link
Contributor Author

clangenb commented Aug 1, 2023

Alright, thanks a lot! 👍

@clangenb
Copy link
Contributor Author

clangenb commented Aug 1, 2023

Rebased on master and merge into master here #1399

@clangenb clangenb closed this Aug 1, 2023
@clangenb clangenb deleted the cl/fix-w2-startup branch August 14, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants