Skip to content

Add missing return to avoid closing the connection twice #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add missing return to avoid closing the connection twice #1309

wants to merge 1 commit into from

Conversation

Kailai-Wang
Copy link
Contributor

resolves #1308

Without it the ws connection is closed twice and might cause panic.

@clangenb
Copy link
Contributor

Ah, I realize now, that we are currently restructuring the CI, such that we can't run PRs from forks. @mosonyi , @OverOrion how far are we from fixing this?

@OverOrion
Copy link
Contributor

Hey @Kailai-Wang

Thank you very much for the PR, it is much appreciated. As @clangenb have already said, we can't accept PRs from forks as of now.

If it is alright with you I will crate a new branch with your commit and open a new PR, so the CI will be able to run. Is that okay with you?

@Kailai-Wang
Copy link
Contributor Author

Hey @Kailai-Wang

Thank you very much for the PR, it is much appreciated. As @clangenb have already said, we can't accept PRs from forks as of now.

If it is alright with you I will crate a new branch with your commit and open a new PR, so the CI will be able to run. Is that okay with you?

Sure, please go ahead :)

@OverOrion
Copy link
Contributor

Superseded by #1320

@OverOrion OverOrion closed this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Occasional panick when closing ws connection in CLI
3 participants