Skip to content

schema: Use schema repository via submodule #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2024
Merged

schema: Use schema repository via submodule #721

merged 1 commit into from
Apr 22, 2024

Conversation

bjhargrave
Copy link
Contributor

This avoids the need to duplicate the schema files in this repository.

@bjhargrave bjhargrave requested review from a team as code owners April 18, 2024 20:21
@github-actions github-actions bot added the ci label Apr 18, 2024
@bjhargrave bjhargrave mentioned this pull request Apr 18, 2024
Closed
7 tasks
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 22, 2024
@bjhargrave bjhargrave force-pushed the schema-submodule branch 2 times, most recently from 93d1da6 to d13d7af Compare April 22, 2024 15:51
ckadner
ckadner approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@bjhargrave
schema: Use schema repository via submodule
9d727c1 
This avoids the need to duplicate the schema files in this repository.

Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
lehors
lehors approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I hope it works (I didn't have a chance to try it yet).

lehors
lehors reviewed Apr 22, 2024
View reviewed changes
@bjhargrave bjhargrave merged commit cd6a736 into instructlab:main Apr 22, 2024
@bjhargrave bjhargrave deleted the schema-submodule branch April 22, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckadner ckadner ckadner approved these changes

+1 more reviewer

@lehors lehors lehors approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ci documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjhargrave @lehors @ckadner