Skip to content

Fix example type #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2024
Merged

Fix example type #1134

merged 1 commit into from
May 28, 2024

Conversation

spzala
Copy link
Contributor

@spzala spzala commented May 28, 2024

It is YAML example for knowledge as changed in the PR (vs skills example).

If your PR is related to a contribution to the taxonomy, please, fill
out the following questionnaire. If not, replace this whole text and the
following questionnaire with whatever information is applicable to your PR.

Contribution checklist

  • The contribution was tested with ilab generate
  • No errors or warnings were produced by ilab generate
  • [ x] All commits are signed off (DCO)
  • The qna.yaml file contains at least 5 seed_examples
  • The qna.yaml file was linted and prettified (yaml-validator can do both)
  • An attribution.txt file in the same folder as the qna.yaml file
  • [ x] Content does not include PII or otherwise sensitive or confidential information
  • [ x] Content does not include anything documented in the project's Avoid these Topics guidelines

@spzala
Fix example type
d2b3f92 
It is YAML example for knowledge as changed in the PR (vs skills example).

Signed-off-by: Sahdev Zala <spzala@us.ibm.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 28, 2024
@bjhargrave bjhargrave merged commit b497757 into instructlab:main May 28, 2024
@spzala
Copy link
Contributor Author

spzala commented May 28, 2024

Thanks @bjhargrave

jjasghar pushed a commit to luke-inglis/taxonomy that referenced this pull request Jun 7, 2024
@spzala @jjasghar
Fix example type (instructlab#1134)
db67c2e 
It is `YAML example` for knowledge as changed in the PR (vs `skills
example`).

Signed-off-by: Sahdev Zala <spzala@us.ibm.com>
jjasghar pushed a commit to acidonper/taxonomy that referenced this pull request Jun 10, 2024
@spzala @jjasghar
Fix example type (instructlab#1134)
42108cc 
It is `YAML example` for knowledge as changed in the PR (vs `skills
example`).

Signed-off-by: Sahdev Zala <spzala@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjhargrave bjhargrave bjhargrave approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spzala @bjhargrave