Skip to content

Fixes for the linter #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2024
Merged

Fixes for the linter #1166

merged 1 commit into from
Jun 6, 2024

Conversation

jjasghar
Copy link
Member

@jjasghar jjasghar commented Jun 5, 2024

These were created before the

  • version: 2 was required
  • attribution.txt was also required

@github-actions github-actions bot added triage-needed (Auto labeled) skill is ready to be triaged skill (Auto labeled) labels Jun 5, 2024
@instruct-lab-bot instruct-lab-bot
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands.

@jjasghar jjasghar removed the skill (Auto labeled) label Jun 5, 2024
@jjasghar jjasghar force-pushed the jjasghar/linting_misses branch from b97a3d2 to ba57882 Compare June 5, 2024 23:32
@github-actions github-actions bot added the skill (Auto labeled) label Jun 5, 2024
@instruct-lab-bot instruct-lab-bot
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands.

@jjasghar @Mohit-Gaur
@vishnoianil @grdryn
Fixes for the linter
569f36c 
Theses where created before the
- version: 2 was required
- attribution.txt was also required

Signed-off-by: JJ Asghar <awesome@ibm.com>
Co-authored-by: Mohit Gaur <56885276+Mohit-Gaur@users.noreply.github.com>
Co-authored-by: Anil Kumar Vishnoi <avishnoi@redhat.com>
Co-authored-by: Gerard Ryan <git@grdryn.xyz>
@jjasghar jjasghar force-pushed the jjasghar/linting_misses branch from ba57882 to 569f36c Compare June 5, 2024 23:33
grdryn
grdryn approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@grdryn grdryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this: I had noticed the lint failure after my PR was merged and thankfully found this before I dug any deeper and prepared a separate change 🙂

@jjasghar jjasghar merged commit a91b670 into main Jun 6, 2024
jjasghar added a commit to luke-inglis/taxonomy that referenced this pull request Jun 7, 2024
@jjasghar @Mohit-Gaur
@vishnoianil @grdryn
Fixes for the linter (instructlab#1166)
690468a 
These were created before the
- version: 2 was required
- attribution.txt was also required

Signed-off-by: JJ Asghar <awesome@ibm.com>
Co-authored-by: Mohit Gaur <56885276+Mohit-Gaur@users.noreply.github.com>
Co-authored-by: Anil Kumar Vishnoi <avishnoi@redhat.com>
Co-authored-by: Gerard Ryan <git@grdryn.xyz>
jjasghar added a commit to acidonper/taxonomy that referenced this pull request Jun 10, 2024
@jjasghar @Mohit-Gaur
@vishnoianil @grdryn
Fixes for the linter (instructlab#1166)
b4b455f 
These were created before the
- version: 2 was required
- attribution.txt was also required

Signed-off-by: JJ Asghar <awesome@ibm.com>
Co-authored-by: Mohit Gaur <56885276+Mohit-Gaur@users.noreply.github.com>
Co-authored-by: Anil Kumar Vishnoi <avishnoi@redhat.com>
Co-authored-by: Gerard Ryan <git@grdryn.xyz>
@jjasghar jjasghar deleted the jjasghar/linting_misses branch August 21, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjhargrave bjhargrave bjhargrave approved these changes

+1 more reviewer

@grdryn grdryn grdryn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
skill (Auto labeled) triage-needed (Auto labeled) skill is ready to be triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjasghar @bjhargrave @grdryn