Use matrix configuration for tox #954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53f4657 to
e22891d
Compare
The previous `tox.ini` used fixed testenvs that used the default `basepython`, which typically points to `python3`. It was not easily possible to run tests with another Python version. The new configuration uses tox's matrix configuration feature. The default targets for tests are now `py3-unit`, `py3-unitcov`, and `py3-functional`. These targets use `python3` as base Python. With the new configurion it's now possible to run tests with different Python versions. For example `tox -e py39-unit` runs unit tests with `python3.9`. Tox is also configured to use wheel with a common wheel env for sdist and binary wheel dist. This speeds up purelib wheel creation. Signed-off-by: Christian Heimes <cheimes@redhat.com>
|
The PR is a prerequisite to test InstructLab with multiple Python versions. A common approach is tox-gh-actions, Python matrix in GHA, and a mapping of GHA env to tox env in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Description of your changes:
The previous
tox.iniused fixed testenvs that used the defaultbasepython, which typically points topython3. It was not easily possible to run tests with another Python version.The new configuration uses tox's matrix configuration feature. The default targets for tests are now
py3-unit,py3-unitcov, andpy3-functional. These targets usepython3as base Python. With the new configurion it's now possible to run tests with different Python versions. For exampletox -e py39-unitruns unit tests withpython3.9.Tox is also configured to use wheel with a common wheel env for sdist and binary wheel dist. This speeds up purelib wheel creation.