Restore the note about regen.json #929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellb
requested changes
Apr 23, 2024
README.md
Outdated
Comment on lines
282
to
296
| > **NOTE:** If you want to pickup from where a failed or canceled `ilab generate` left off, you can copy the `generated*.json` file into a file named `regen.json`. `regen.json` will be picked up at the start of `lab generate` when available. You should remove it when the process is completed. | ||
|
|
There was a problem hiding this comment.
Suggested change
| > **NOTE:** If you want to pickup from where a failed or canceled `ilab generate` left off, you can copy the `generated*.json` file into a file named `regen.json`. `regen.json` will be picked up at the start of `lab generate` when available. You should remove it when the process is completed. | |
| > [!NOTE] | |
| > If you want to pickup from where a failed or canceled `ilab generate` left off, you can copy the | |
| > `generated*.json` file into a file named `regen.json`. `regen.json` will be picked up at the start of `lab | |
| > generate` when available. You should remove it when the process is completed. |
There was a problem hiding this comment.
that does look better but now its not the same style as other notes in this file
There was a problem hiding this comment.
Well maybe another pr can convert the rest 😀
This was removed weeks ago during an update of the README. The code still exists and it still works. Fixes instructlab#156 Signed-off-by: Derek Higgins <derekh@redhat.com>
russellb
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was removed weeks ago during an update of the README. The code still exists and it still works.
Fixes #156