fix: openai and http log level #924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Previous reviews can be found at #872 |
Lately, more INFO messages have appeared in the chat, so let's set the log level to ERROR only on the openai and http clients. Without this change: ``` $ ilab chat INFO 2024-04-16 11:49:33,283 _base_client.py:1040 Retrying request to /models in 0.911925 seconds INFO 2024-04-16 11:49:34,197 _base_client.py:1040 Retrying request to /models in 1.571945 seconds ``` A more granular control over the log levels for various libraries will be implemented in a follow-up PR. That enhancement is tracked in instructlab#905. Signed-off-by: Sébastien Han <seb@redhat.com>
nathan-weinberg
approved these changes
Apr 24, 2024
alimaredia
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lately, more INFO messages have appeared in the chat, so let's set the log level to ERROR only on the openai and http clients.
Without this change:
A more granular control over the log levels for various libraries will be implemented in a follow-up PR. That enhancement is tracked in #905.
Resolves: #909
Signed-off-by: Sébastien Han seb@redhat.com