Fix TypeError during ilab generate
#893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the `working_dir` of a repo object, not the repo object as base
directory for globbing. Fixes:
```
File "cli/utils.py", line 229, in get_documents
for file_path in glob.glob(os.path.join(working_dir, pattern)):
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "<frozen posixpath>", line 76, in join
TypeError: expected str, bytes or os.PathLike object, not Repo
```
Replace the mock.patch with a proper spec-ed Mock that walks and talks
like a `git.Repo` object. This makes the code easier to understand and
does not violate the type annotations.
Fixes: #885
Signed-off-by: Christian Heimes <cheimes@redhat.com>
2dd58ec to
e215dcc
Compare
bjhargrave
approved these changes
Apr 17, 2024
anik120
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Which issue is resolved by this Pull Request:
Resolves #885
Description of your changes:
Use the
working_dirof a repo object, not the repo object as base directory for globbing. Fixes:Replace the mock.patch with a proper spec-ed Mock that walks and talks like a
git.Repoobject. This makes the code easier to understand and does not violate the type annotations.