Skip to content

Conversation

hickeyma
Copy link
Member

@hickeyma hickeyma commented Apr 16, 2024

No description provided.

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
@hickeyma hickeyma force-pushed the chore/align-licenses branch from 08f9fa8 to 502cced Compare April 16, 2024 16:11
- Notice file to contain license info
- Add details on mlx_explore originality

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
@hickeyma hickeyma force-pushed the chore/align-licenses branch from 510bd9d to 805f28e Compare April 16, 2024 16:39
@hickeyma hickeyma requested a review from russellb April 16, 2024 16:42
@hickeyma hickeyma changed the title chore: Update licensing chore: Update licensing for included code Apr 16, 2024
@hickeyma hickeyma changed the title chore: Update licensing for included code chore: Update the license content for included code Apr 16, 2024
@hickeyma hickeyma requested a review from jaideepr97 April 16, 2024 16:53
Copy link
Contributor

@mrutkows mrutkows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, move all copied LICENSE files under a parent licensing folder to follow more modern conventions and so all these files do not confuse downstream tools/scanners and can more easily be excluded from similar tools via a single folder reference.

Copy link
Member

@jaideepr97 jaideepr97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @hickeyma
Thanks!

@hickeyma hickeyma requested a review from mrutkows April 16, 2024 17:14
Copy link
Contributor

@mrutkows mrutkows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with the results of the conversations on the previous advice/questions provided and feel that I can add my approval.

+1 from me...

@russellb russellb merged commit 6264bcb into instructlab:main Apr 16, 2024
@hickeyma hickeyma deleted the chore/align-licenses branch April 17, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants