Skip to content

Conversation

xukai92
Copy link
Member

@xukai92 xukai92 commented Apr 16, 2024

Changes

Description of your changes:

Borrow the Lab description from the taxonomy repo (https://github.com/instruct-lab/taxonomy?tab=readme-ov-file#welcome-to-the-instructlab-taxonomy) to give an intro + paper info for Lab.

Signed-off-by: Kai Xu <xuk@ibm.com>
Signed-off-by: Kai Xu <xuk@ibm.com>
README.md Outdated
Large Language Models (LLMs.) The "**lab**" in Instruct**Lab** 🥼 stands for
[**L**arge-Scale **A**lignment for Chat**B**ots](https://arxiv.org/abs/2403.01081) [1].

[1] Shivchander Sudalairaj*, Abhishek Bhandwaldar*, Aldo Pareja*, Kai Xu, David D. Cox, Akash Srivastava*. “LAB: Large-Scale Alignment for ChatBots”, arXiv preprint arXiv: 2403.01081, 2024.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should replace the fancy double quotes with plain double quotes. Fancy ones are terrible in code so maybe I'm overreacting here.

Also I think the asterisks next to some names with no explanation is not good. It looks like a footnote, but there is none.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call. let me fix!

Copy link
Member

@markstur markstur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline

Signed-off-by: Kai Xu <xuk@ibm.com>
@xukai92
Copy link
Member Author

xukai92 commented Apr 16, 2024

updated!

Copy link
Member

@markstur markstur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@markstur markstur merged commit 7ae6499 into instructlab:main Apr 16, 2024
@markstur
Copy link
Member

@mrutkows Does this need to be considered in NOTICE too? I think this is different from other attributions, but not sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants