-
Notifications
You must be signed in to change notification settings - Fork 441
docs: use intro to lab from taxonomy + link&citation #875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kai Xu <xuk@ibm.com>
Signed-off-by: Kai Xu <xuk@ibm.com>
README.md
Outdated
Large Language Models (LLMs.) The "**lab**" in Instruct**Lab** 🥼 stands for | ||
[**L**arge-Scale **A**lignment for Chat**B**ots](https://arxiv.org/abs/2403.01081) [1]. | ||
|
||
[1] Shivchander Sudalairaj*, Abhishek Bhandwaldar*, Aldo Pareja*, Kai Xu, David D. Cox, Akash Srivastava*. “LAB: Large-Scale Alignment for ChatBots”, arXiv preprint arXiv: 2403.01081, 2024. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should replace the fancy double quotes with plain double quotes. Fancy ones are terrible in code so maybe I'm overreacting here.
Also I think the asterisks next to some names with no explanation is not good. It looks like a footnote, but there is none.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call. let me fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see inline
Signed-off-by: Kai Xu <xuk@ibm.com>
updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@mrutkows Does this need to be considered in NOTICE too? I think this is different from other attributions, but not sure |
Changes
Description of your changes:
Borrow the Lab description from the
taxonomy
repo (https://github.com/instruct-lab/taxonomy?tab=readme-ov-file#welcome-to-the-instructlab-taxonomy) to give an intro + paper info for Lab.