Skip to content

Conversation

hickeyma
Copy link
Member

@hickeyma hickeyma commented Apr 15, 2024

Description of your changes:

Removes files that are no longer used. Files as follows:

  • .github/actions/free-up-disk-space/action.yml: This was used previously before to clean up space of GH runners until caching and re-use of system site packages for the test environments was configured.
  • README.snippets.md: Seems to have been a misplaced file
  • cli/train/mlx-training.md: Old "happy path" workflow file
  • mac_inference/*: Initial investigation work where the basis for serving and inferencing models was researched before being added to the CLI.
  • testrun.sh: Replaced with the functional tests.

@hickeyma hickeyma added this to the Milestone 4/18 milestone Apr 15, 2024
@hickeyma hickeyma added the chore You gotta do what you gotta do label Apr 15, 2024
@hickeyma hickeyma force-pushed the chore/remove-deprecated-files branch from 1c2f405 to 713d82c Compare April 16, 2024 13:46
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
@hickeyma hickeyma force-pushed the chore/remove-deprecated-files branch from 713d82c to 3b7bae0 Compare April 16, 2024 13:47
@alimaredia alimaredia self-requested a review April 16, 2024 14:37
Copy link
Member

@markstur markstur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good cleanup, thanks!

@markstur markstur merged commit 0b0eb16 into instructlab:main Apr 16, 2024
@hickeyma hickeyma deleted the chore/remove-deprecated-files branch April 16, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore You gotta do what you gotta do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants