diff: Rework --quiet logic and handle file without needing --quiet #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic is organized so there is not separate work paths for quiet and non-quiet. The code now properly identifies and handles single files. An exception in the non-quiet code when reading the repo now results in a failing exit code. Fixes #796 Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
|
@bjhargrave Is this reopened anywhere? We have this marked as a P1 bugfix on the CLI board |
|
I will resubmit this morning. Need to rebase anyway since the files I changed were relocated. |
|
Replaced by #959. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Which issue is resolved by this Pull Request:
Resolves #796
Description of your changes:
The logic is organized so there is not separate work paths for quiet and non-quiet. The non-quiet code now properly identifies and handles single files.
An exception in the quiet code when reading the repo now results in a
failing exit code.