Improve ROCm container and documentation #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0a5108d to
3269cb7
Compare
3269cb7 to
9adfcbe
Compare
9adfcbe to
9fd72f8
Compare
784de48 to
51e59b9
Compare
|
this needs to be reviewed for merge, should be ready to go |
|
@cdoern hey mind reviewing this? |
- Use Python 3.11 so we can experiment with PyTorch's JIT compiler - Suggest Python 3.11 for PyTorch JIT in `README.md` - Fix typo in ROCm `README.md` (it's container*s*) - Mention ROCm container in `gpu-acceleration.md` - Use `clang-17` to build ROCm code - Fix various issues with Makefile - Replace `chcon` workaround with a patched `shutil` Signed-off-by: Christian Heimes <cheimes@redhat.com>
51e59b9 to
cf8dd66
Compare
|
I have rebased the PR and resolved two merge conflicts. |
cdoern
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
README.mdREADME.md(it's containers)gpu-acceleration.md