Skip to content

Fix tox -e spellcheck #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2024
Merged

Fix tox -e spellcheck #1014

merged 1 commit into from
Apr 29, 2024

Conversation

tiran
Copy link
Contributor

@tiran tiran commented Apr 26, 2024 •
edited
Loading

Changes

Which issue is resolved by this Pull Request:
Resolves #999

Description of your changes:
Remove quotes around spellcheck in tox.ini. Use tox -e spellcheck in CI, so we test our own spellcheck code.

Run all GHA jobs whenever a file in .github/** has been modified.

@github-actions github-actions bot added the testing Relates to testing label Apr 26, 2024
@tiran tiran force-pushed the fix-spellcheck branch 2 times, most recently from 942c4aa to 5882437 Compare April 26, 2024 07:10
russellb
russellb approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but it needs a rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 29, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. @tiran please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase This Pull Request needs to be rebased label Apr 29, 2024
@tiran
Fix tox -e spellcheck
cc1292e 
Remove quotes around spellcheck in tox.ini. Use `tox -e spellcheck` in
CI, so we test our own spellcheck code.

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@mergify mergify bot removed the needs-rebase This Pull Request needs to be rebased label Apr 29, 2024
@mergify mergify bot merged commit 4c1f09a into instructlab:main Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russellb russellb russellb approved these changes

@leseb leseb leseb approved these changes

Assignees
No one assigned
Labels
testing Relates to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tox -e spellcheck fails
3 participants
@tiran @russellb @leseb