Skip to content

ci: add markdown linter #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 26, 2024
Merged

ci: add markdown linter #1013

merged 5 commits into from
Apr 26, 2024

Conversation

nathan-weinberg
Copy link
Member

Adds a Markdown Linter - needs some testing before merge - I'll review the hold label and add reviewers once I feel it's ready

@nathan-weinberg nathan-weinberg added the hold In-progress PR. Tag should be removed before merge. label Apr 26, 2024
@nathan-weinberg
ci: add markdown linter
9b69077 
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
tiran
tiran reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea to link markdown files, too.

nathan-weinberg and others added 2 commits April 26, 2024 11:07
@nathan-weinberg @tiran
Update ignorelist
31c60e7 
Co-authored-by: Christian Heimes <cheimes@redhat.com>
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
@nathan-weinberg
Fix all lint errors
87c773b 
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 26, 2024
@nathan-weinberg nathan-weinberg removed the hold In-progress PR. Tag should be removed before merge. label Apr 26, 2024
@nathan-weinberg
Add 'repo' to spellcheck dictionary
ab5869f 
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
@nathan-weinberg nathan-weinberg requested a review from a team April 26, 2024 16:18
@nathan-weinberg
Copy link
Member Author

This should be good to go

russellb
russellb reviewed Apr 26, 2024
View reviewed changes
russellb
russellb reviewed Apr 26, 2024
View reviewed changes
russellb
russellb approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One follow-up is to block merging on this job passing in the mergify config

@nathan-weinberg
Bump container image to match GHA and fix remaining rules/linting
d8202bf 
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
@nathan-weinberg nathan-weinberg added the CI/CD Affects CI/CD configuration label Apr 26, 2024
@russellb
Copy link
Member

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 26, 2024

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 6f5f5e8 into instructlab:main Apr 26, 2024
@nathan-weinberg nathan-weinberg deleted the md-lint branch April 26, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran tiran left review comments

@russellb russellb russellb approved these changes

Assignees
No one assigned
Labels
CI/CD Affects CI/CD configuration documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nathan-weinberg @russellb @tiran