-
Notifications
You must be signed in to change notification settings - Fork 440
Define a relaxed schema as v1 and move current schema to v2 #1009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR will need rebasing once #913 and instructlab/schema#11 are merged. |
This pull request has merge conflicts that must be resolved before it can be |
74ff825
to
4f89987
Compare
@bjhargrave can you clarify the |
#913 is now merged. But we also need to merge instructlab/schema#11 before this PR. I did not merge the schema PR until we agreed to this overall schema v1/v2 concept in the cli. |
@russellb It would be nice to get a review on this since the issue addressed by this PR is in the 5/2 milestone. |
@bjhargrave it should now merge once you remove the |
schema: Define a relaxed schema as v1 and move current schema to v2 See instructlab/instructlab#1009
We introduce a relaxed schema as v1 which will accept all existing taxonomy files in the main branch of the taxonomy repo. The current v1 schema is renamed to v2 and will be used for future contributions to the taxonomy repo. Fixes instructlab#989 Depends on instructlab#913 and instructlab/schema#11 Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
4f89987
to
1d2498e
Compare
Changes
Which issue is resolved by this Pull Request:
Resolves #989
Description of your changes:
We introduce a relaxed schema as v1 which will accept all existing
taxonomy files in the main branch of the taxonomy repo. The current
v1 schema is renamed to v2 and will be used for future contributions
to the taxonomy repo.
Fixes #989
Depends on #913
and instructlab/schema#11