-
Notifications
You must be signed in to change notification settings - Fork 441
ci: add stale issue/PR bot #1000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add stale issue/PR bot #1000
Conversation
.github/workflows/stale_bot.yml
Outdated
stale-pr-label: 'stale' | ||
stale-pr-message: > | ||
This pull request has been automatically marked as stale because it has not had activity within 90 days. | ||
It will be automatically closed if no further activity occurs within 30 days. | ||
close-pr-message: > | ||
This pull request has been automatically closed due to inactivity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name mentions both PRs and issues, the messages/configuration in this file is only for PRs, though. Regarding the wording, it would be nice to guide the submitter in the message with what's expected to be done here as well. I believe in Ansible, their bot also asks a question like "What can you do to move this forward?" to encourage the submitter to take action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good points @tyll - any suggestions for text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I add some minor changes, but feel free to make further suggestions, want this to be as contributor-friendly as possible while also keeping a realistic backlog for the maintainers 😄
In taxonomy, we were mostly focused on managing PRs. But here you will also need to manage issues. So some additional config is needed. |
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
f96c254
to
8cdc511
Compare
My first thought was that maybe since we just opened up we might wait a month or so before marking anything stale, but then I looked at our oldest issues and considered the 90 day thing and decided this is good already. Thought I'd comment in case anyone is thinking "too soon" |
Also (this isn't very intuitive in the config IMO) right now it's 90 days to stale, then another 30 before anything is auto-closed, so nothing should get auto-closed unless it's been 120 days since any activity (four months, or one fiscal quarter 😉) |
I'd approve this except for the fiscal quarter comment |
I will merge for now, and we can iterate on the config if folks have more thoughts |
congrats on getting PR #1000 btw! 🎉 |
This PR adds a stale issue bot similar to what we have in the
taxonomy
repo: https://github.com/instructlab/taxonomy/blob/main/.github/workflows/stale_bot.ymlThis is also a proposal of sorts - if we feel this isn't something worth having in this repo, I'm happy to close it.