Skip to content

Conversation

nathan-weinberg
Copy link
Member

This PR adds a stale issue bot similar to what we have in the taxonomy repo: https://github.com/instructlab/taxonomy/blob/main/.github/workflows/stale_bot.yml

This is also a proposal of sorts - if we feel this isn't something worth having in this repo, I'm happy to close it.

@nathan-weinberg nathan-weinberg added the CI/CD Affects CI/CD configuration label Apr 25, 2024
@nathan-weinberg nathan-weinberg requested a review from a team April 25, 2024 16:12
Comment on lines 16 to 21
stale-pr-label: 'stale'
stale-pr-message: >
This pull request has been automatically marked as stale because it has not had activity within 90 days.
It will be automatically closed if no further activity occurs within 30 days.
close-pr-message: >
This pull request has been automatically closed due to inactivity.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name mentions both PRs and issues, the messages/configuration in this file is only for PRs, though. Regarding the wording, it would be nice to guide the submitter in the message with what's expected to be done here as well. I believe in Ansible, their bot also asks a question like "What can you do to move this forward?" to encourage the submitter to take action.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good points @tyll - any suggestions for text?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add some minor changes, but feel free to make further suggestions, want this to be as contributor-friendly as possible while also keeping a realistic backlog for the maintainers 😄

@bjhargrave
Copy link
Contributor

In taxonomy, we were mostly focused on managing PRs. But here you will also need to manage issues. So some additional config is needed.

Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
@nathan-weinberg nathan-weinberg requested a review from tyll April 25, 2024 21:07
@nathan-weinberg nathan-weinberg changed the title ci: add stale issue bot ci: add stale issue/PR bot Apr 25, 2024
@markstur
Copy link
Member

My first thought was that maybe since we just opened up we might wait a month or so before marking anything stale, but then I looked at our oldest issues and considered the 90 day thing and decided this is good already.

Thought I'd comment in case anyone is thinking "too soon"

@nathan-weinberg
Copy link
Member Author

My first thought was that maybe since we just opened up we might wait a month or so before marking anything stale, but then I looked at our oldest issues and considered the 90 day thing and decided this is good already.

Thought I'd comment in case anyone is thinking "too soon"

Also (this isn't very intuitive in the config IMO) right now it's 90 days to stale, then another 30 before anything is auto-closed, so nothing should get auto-closed unless it's been 120 days since any activity (four months, or one fiscal quarter 😉)

@markstur
Copy link
Member

I'd approve this except for the fiscal quarter comment

@nathan-weinberg
Copy link
Member Author

I will merge for now, and we can iterate on the config if folks have more thoughts

@nathan-weinberg nathan-weinberg merged commit 799409b into instructlab:main Apr 25, 2024
@nathan-weinberg nathan-weinberg deleted the stale-issue-bot branch April 25, 2024 23:20
@russellb
Copy link
Member

congrats on getting PR #1000 btw! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Affects CI/CD configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants