Add support for --insecure-skip-tls-verify option #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Geoff Baskwill <me@geoffbaskwill.ca>
Some users are stuck behind corporate HTTP proxies that MITM all traffic and are forced to sacrifice TLS security. This allows those users to use the tool despite the proxy messing with the certificates. Signed-off-by: Geoff Baskwill <me@geoffbaskwill.ca>
|
@garethr I'm sure you're super-busy at Kubecon this week so you might not get a chance to look at this right away. I'm happy to make any changes that you would like, just dashed this off without looking around too much for what else might be needed to round this PR out. |
|
@garethr ping? |
|
@garethr one last ping before the holidays, is this interesting / useful or should I close as unwanted? |
|
Thanks for the pull request, much appreciated. Just getting back to a bunch of maintenance on this project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users are stuck behind corporate HTTP proxies that MITM all traffic and are forced to sacrifice TLS security. This allows those users to use the tool despite the proxy messing with the certificates.
It would be great to continue down this path and provide a more secure option, like what
kubectldoes with the--certificate-authorityoption.Fixes #197.