Basic schema cache #129
Merged
Basic schema cache #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johanneswuerbach this is great, much appreciated. I'll try this out and get a new release of kubeval out with this. Thanks for the functionality and the tests too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing in multiple files each schema is downloaded multiple times.
This PR introduces a simple in-memory cache to download required schemas only once during a validation run.
It uses the approach described in https://github.com/xeipuuv/gojsonschema/blob/master/README.md#validation to share load the schema only once.
This reduces the validation time of our ~1k yaml files from 5 mins to ~10s.